Fix some ansible-lint complaints.

roles/dns-dhcp-tftp/tasks/main.yml

@@ -12,7 +12,7 @@
       - isc-dhcp-server
       - tftpd-hpa
       - bind9
-    state: latest
+    state: latest # noqa package-latest
 
 ## FIXME: preseeding seems to be ignored
 - name: configure TFTP root directory
@@ -22,7 +22,7 @@
     replace: 'TFTP_DIRECTORY="/var/lib/tftpboot"'
   notify: restart tftpd-hpa
 
-- name: serve dhcp on LAN interface       
+- name: serve dhcp on LAN interface
   replace:
     path: /etc/default/isc-dhcp-server
     regexp: '^INTERFACESv4=".*"$'
@@ -33,13 +33,15 @@
   template:
     src: dhcpd.conf.j2
     dest: /etc/dhcp/dhcpd.conf
-    backup: yes
+    mode: 0644
+    backup: true
   notify: restart isc-dhcp-server
 
-- name: deploy config files for bind9 
+- name: deploy config files for bind9
   template:
     src: "{{ item }}.j2"
     dest: "/etc/bind/{{ item }}"
+    mode: 0644
   loop:
     - db.intern
     - localzones
@@ -49,6 +51,7 @@
   template:
     src: db.lan.j2
     dest: "/etc/bind/db.{{ ipaddr_lan_threeoct }}"
+    mode: 0644
   notify: restart bind
 
 - name: link zone files to writeable directory for DDNS
@@ -71,6 +74,7 @@
   template:
     src: resolv.conf.j2
     dest: /etc/resolv.conf
+    mode: 0644
   notify: restart isc-dhcp-server
 
 ## stop dhclient from overwriting /etc/resolv.conf:
@@ -80,7 +84,7 @@
     block: |
       supersede domain-search "{{ ansible_domain }}";
       supersede domain-name-servers 127.0.0.1;
-    insertbefore: "#send dhcp-client-identifier.*" 
+    insertbefore: "#send dhcp-client-identifier.*"
   notify: restart dhcp-client
 
 - name: generate rndc key
@@ -90,11 +94,10 @@
 
 - name: copy rndc key
   copy:
-    src: /etc/bind/rndc.key 
+    src: /etc/bind/rndc.key
     dest: /etc/dhcp/
-    owner: root 
+    owner: root
     group: root
-    mode: '0640'
-    remote_src: yes  
+    mode: 0640
+    remote_src: true
   notify: restart isc-dhcp-server
-

roles/dns-dhcp-tftp/templates/dhcpd.conf.j2

@@ -56,7 +56,7 @@ subnet {{ ipaddr_lan | ipaddr("network") }} netmask {{ ipaddr_lan | ipaddr("netm
 }
 
 
-# No service will be given on this subnet, but declaring it helps the 
+# No service will be given on this subnet, but declaring it helps the
 # DHCP server to understand the network topology.
 
 #subnet 10.152.187.0 netmask 255.255.255.0 {