Fix some ansible-lint complaints.

roles/samba-ldap/handlers/main.yml

@@ -5,4 +5,3 @@
 - name: restart smbd
   service: name=smbd state=restarted enabled=yes
   listen: "restart smbd"
-

roles/samba-ldap/meta/main.yml

@@ -1,3 +1,3 @@
 ---
-dependencies:
+dependencies: # noqa meta-no-info
   - role: ldap

roles/samba-ldap/tasks/main.yml

@@ -9,8 +9,7 @@
     name:
       - samba
       - sssd-ldap
-    state: latest
-
+    state: latest # noqa package-latest
 
 - name: provide identities from LDAP
   template:
@@ -19,8 +18,8 @@
     mode: 0600
   notify: restart sssd
 
-- meta: flush_handlers
-
+- name: flush all handlers
+  meta: flush_handlers
 
 - name: prepare samba schema
   command: cp /usr/share/doc/samba/examples/LDAP/samba.ldif /etc/ldap/schema/
@@ -87,8 +86,8 @@
 - name: slurp admin password for samba setup
   slurp:
     src: "{{ ldap_admin_pwd_file }}"
-  register: ldap_admin_pwd 
-  no_log: true  
+  register: ldap_admin_pwd
+  no_log: true
   when: not samba_ldap.stat.exists
 
 - name: make samba admin password available to smbd
@@ -97,9 +96,10 @@
   notify: restart smbd
   when: not samba_ldap.stat.exists
 
-- meta: flush_handlers
+- name: flush all handlers
+  meta: flush_handlers
 
-- name: add samba attributes to dummy user foo 
+- name: add samba attributes to dummy user foo
   command:
     cmd: smbpasswd -s -a foo
     stdin: "{{ foo_pwd }}\n{{ foo_pwd }}"
@@ -111,8 +111,8 @@
   firewalld:
     zone: internal
     service: "{{ item }}"
-    permanent: yes
-    immediate: yes
+    permanent: true
+    immediate: true
     state: enabled
   with_items:
     - samba

roles/samba-ldap/templates/sssd.conf.j2

@@ -19,5 +19,5 @@ cache_credentials = true
 min_id = {{ min_id_sssd }}
 max_id = {{ max_id_sssd }}
 
-## remove this after providing propper certificates: 
+## remove this after providing propper certificates:
 ldap_tls_reqcert = allow